[PATCH] D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor.

Kai Nacke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 15:39:01 PDT 2022


Kai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCRegisterBankInfo.cpp:80
+    break;
+  case TargetOpcode::COPY: {
+    Register DstReg = MI.getOperand(0).getReg();
----------------
shchenz wrote:
> Maybe we could move this to target independent handling at line 50? `getInstrMappingImpl` should able to handle case where register bank of one operand of the copy instruction is known.
Good point, I changed the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127530/new/

https://reviews.llvm.org/D127530



More information about the llvm-commits mailing list