[PATCH] D127530: [PowerPC] Extend GlobalISel implementation to emit and/or/xor.

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 15:26:57 PDT 2022


tschuett added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:45
+
+  void assignValueToAddress(Register ValVReg, Register Addr, LLT MemTy,
+                            MachinePointerInfo &MPO, CCValAssign &VA) override {
----------------
Could you move the implementations out of the anonymous namespace?
https://llvm.org/docs/CodingStandards.html#anonymous-namespaces


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127530/new/

https://reviews.llvm.org/D127530



More information about the llvm-commits mailing list