[PATCH] D135219: [PassTimingInfo] Stop double (or worse) counting passes/analyses

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added reviewers: asbirlea, ychen.
Herald added a subscriber: hiraditya.
Herald added a project: All.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

If we nest timers, we end up double counting anything nested.

The most egregious is ModuleInlinerWrapperPass/DevirtSCCRepeatedPass showing up as >20% of the total time when they're just wrappers.

Analyses also end up getting counted multiple times because they're nested inside wrappers and passes.

Ignore ModuleInlinerWrapperPass/DevirtSCCRepeatedPass. And for now, remove timing analyses. Timing analyses is useful, but currently the numbers are misleading.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135219

Files:
  llvm/include/llvm/IR/PassTimingInfo.h
  llvm/lib/IR/PassTimingInfo.cpp
  llvm/test/Other/time-passes.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135219.465200.patch
Type: text/x-patch
Size: 4135 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221004/0e3e7940/attachment.bin>