[PATCH] D135166: [DebugInfo] getMergedLocation: Maintain the line number if they match
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 4 12:32:57 PDT 2022
dblaikie added a comment.
I'm cautious about adding a one-off iterator abstraction as is done here - meeting iterator requirements is non-trivial (eg: returning values from op* is questionable - since then to the iterator requirements you also need op-> which can't return by value... ). So might be best sticking with the existing code style of an explicit loop.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135166/new/
https://reviews.llvm.org/D135166
More information about the llvm-commits
mailing list