[PATCH] D135014: [lld][ELF] Fix lazy ThinLTO index writing in thin archives

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-emit-index-thin-archive.ll:3
+
+;; Setup
+; RUN: rm -rf %t.dir && mkdir %t.dir && cd %t.dir
----------------
Delete `;; Setup`. It's not useful


================
Comment at: lld/test/ELF/lto/thinlto-emit-index-thin-archive.ll:5
+; RUN: rm -rf %t.dir && mkdir %t.dir && cd %t.dir
+; RUN: mkdir dir1
+; RUN: mkdir dir2
----------------
`mkdir dir1 dir2`


================
Comment at: lld/test/ELF/lto/thinlto-emit-index-thin-archive.ll:40
+
+; CHECK-WHOLE-ARCHIVE: lib.a(unused.o at {{[1-9][0-9]+}})
+
----------------
Rename `CHECK-UNUSED` and just reuse its check since the pattern is exactly the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135014/new/

https://reviews.llvm.org/D135014