[PATCH] D135040: [llvm-objdump] Add --no-addresses as an alias for --no-leading-addr

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 10:01:50 PDT 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rG5c7566cd0597: [llvm-objdump] Add --no-addresses as an alias for --no-leading-addr (authored by MaskRay).

Changed prior to commit:
  https://reviews.llvm.org/D135040?vs=464569&id=465063#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135040/new/

https://reviews.llvm.org/D135040

Files:
  llvm/docs/CommandGuide/llvm-objdump.rst
  llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs-exec.test
  llvm/test/tools/llvm-objdump/X86/print-symbol-addr.s
  llvm/tools/llvm-objdump/ObjdumpOpts.td


Index: llvm/tools/llvm-objdump/ObjdumpOpts.td
===================================================================
--- llvm/tools/llvm-objdump/ObjdumpOpts.td
+++ llvm/tools/llvm-objdump/ObjdumpOpts.td
@@ -130,6 +130,7 @@
 
 def no_leading_addr : Flag<["--"], "no-leading-addr">,
   HelpText<"When disassembling, do not print leading addresses for instructions or inline relocations">;
+def : Flag<["--"], "no-addresses">, Alias<no_leading_addr>;
 
 def raw_clang_ast : Flag<["--"], "raw-clang-ast">,
   HelpText<"Dump the raw binary contents of the clang AST section">;
Index: llvm/test/tools/llvm-objdump/X86/print-symbol-addr.s
===================================================================
--- llvm/test/tools/llvm-objdump/X86/print-symbol-addr.s
+++ llvm/test/tools/llvm-objdump/X86/print-symbol-addr.s
@@ -24,6 +24,8 @@
 # RUN: llvm-objdump -d --no-leading-addr %t.64.o > %t.64.txt
 # RUN: FileCheck --input-file=%t.32.txt %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
 # RUN: FileCheck --input-file=%t.64.txt %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
+# RUN: llvm-objdump -d --no-addresses %t.32.o | diff %t.32.txt -
+# RUN: llvm-objdump -d --no-addresses %t.64.o | diff %t.64.txt -
 
 #      NOADDR:<foo>:
 # NOADDR-NEXT: 90{{ +}}	nop
Index: llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs-exec.test
===================================================================
--- llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs-exec.test
+++ llvm/test/tools/llvm-objdump/X86/elf-disassemble-relocs-exec.test
@@ -3,6 +3,7 @@
 # RUN: yaml2obj --docnum=1 %s -o %t
 # RUN: llvm-objdump -dr %t | FileCheck %s --match-full-lines --strict-whitespace
 # RUN: llvm-objdump -dr --no-leading-addr %t | FileCheck %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
+# RUN: llvm-objdump -dr --no-addresses %t | FileCheck %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
 
 # RUN: yaml2obj -DBITS=32 %s -o %t.32
 # RUN: llvm-objdump -dr --no-leading-addr %t.32 | FileCheck %s --check-prefix=NOADDR --match-full-lines --strict-whitespace
Index: llvm/docs/CommandGuide/llvm-objdump.rst
===================================================================
--- llvm/docs/CommandGuide/llvm-objdump.rst
+++ llvm/docs/CommandGuide/llvm-objdump.rst
@@ -184,7 +184,7 @@
   Enable/disable target-specific attributes. Specify ``--mattr=help`` to display
   the available attributes.
 
-.. option:: --no-leading-addr
+.. option:: --no-leading-addr, --no-addresses
 
   When disassembling, do not print leading addresses for instructions or inline
   relocations.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135040.465063.patch
Type: text/x-patch
Size: 2622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221004/31dfccab/attachment.bin>


More information about the llvm-commits mailing list