[PATCH] D135086: [NFC][RISCV] Move getSEWLMULRatio function to header
Anton Sidorenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 4 09:22:11 PDT 2022
asi-sc added inline comments.
================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp:191
+ bool Fractional;
+ std::tie(LMul, Fractional) = decodeVLMUL(VLMul);
+
----------------
frasercrmck wrote:
> I don't know if this is something that benefits from a structured binding.
Honestly, exactly here I don't see any reason to use structured binding as the current solution has better readability (imo) and there is no need for extra optimizations. Though, if anybody has concerns regarding to this, let's use structured bindings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135086/new/
https://reviews.llvm.org/D135086
More information about the llvm-commits
mailing list