[PATCH] D135009: [RISCV] Refactor and improve eliminateFrameIndex.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 4 07:41:56 PDT 2022
reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:209
+ TII->getVLENFactoredAmount(MF, MBB, II, DL, DestReg, ScalableValue);
}
----------------
HsiangKai wrote:
> craig.topper wrote:
> > I wonder if there's any reason we can't add the scalable offset here instead of adding large fixed offset first.
> I think there is no strong reason to do so. eliminateFrameIndex will handle all kinds of FrameIndex operand. At the beginning, we only have fixed offset in the FrameIndex. Handle large offset is the existing code. When implementing RVV frame handling, I just put the RVV related code after the existing code at that time. I wonder if there is any benefit to put the scalable part earlier? If so, I think it makes sense to move it before handling large fixed offset.
@craig.topper I agree that reordering looks legal to me. Would certainly simplify the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135009/new/
https://reviews.llvm.org/D135009
More information about the llvm-commits
mailing list