[PATCH] D135156: [AMDGPU][DAG] Fix insert_vector_elt lowering for 8 bit elements

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 4 07:16:49 PDT 2022


Pierre-vh created this revision.
Pierre-vh added a reviewer: arsenm.
Herald added subscribers: kosarev, foad, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl.
Herald added a project: All.
Pierre-vh requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

The bitmask used to extract the bits assumed 16 bit elements and wasn't taking the size of the elements into account.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135156

Files:
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/test/CodeGen/AMDGPU/insert_vector_dynelt.ll
  llvm/test/CodeGen/AMDGPU/insert_vector_elt.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135156.465000.patch
Type: text/x-patch
Size: 4723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221004/0ec40449/attachment.bin>


More information about the llvm-commits mailing list