[PATCH] D91620: [compiler-rt][test] Heed COMPILER_RT_DEBUG when compiling unittests
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 4 04:50:35 PDT 2022
ro updated this revision to Diff 464957.
ro added a comment.
Herald added a subscriber: Enna1.
Herald added a project: All.
- Update `COMPILER_RT_UNITTEST_CFLAGS` as requested.
- Change `SANITIZER_COMMON_CFLAGS` to `-O0` for `COMPILER_RT_DEBUG`, cannot reliably debug with optimization.
- `compiler-rt/lib/sanitizer_common/tests/sanitizer_type_traits_test.cpp` tests `SanitizerCommon.IsTriviallyDestructible` and `SanitizerCommon.IsTriviallyCopyable` fail to link with debug build:
FAILED: projects/compiler-rt/lib/sanitizer_common/tests/Sanitizer-i386-Test
[...]
Undefined first referenced
symbol in file
_ZN11__sanitizer17integral_constantIbLb1EE5valueE SANITIZER_TEST_OBJECTS.sanitizer_type_traits_test.cpp.i386.o
ld: fatal: symbol referencing errors
Maybe one can provide a definition of `__sanitizer::integral_constant<bool, true>::value`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91620/new/
https://reviews.llvm.org/D91620
Files:
compiler-rt/CMakeLists.txt
compiler-rt/lib/asan/tests/CMakeLists.txt
compiler-rt/lib/fuzzer/tests/CMakeLists.txt
compiler-rt/lib/gwp_asan/tests/CMakeLists.txt
compiler-rt/lib/interception/tests/CMakeLists.txt
compiler-rt/lib/msan/tests/CMakeLists.txt
compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt
compiler-rt/lib/sanitizer_common/tests/sanitizer_type_traits_test.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91620.464957.patch
Type: text/x-patch
Size: 6769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221004/870f5cad/attachment.bin>
More information about the llvm-commits
mailing list