[PATCH] D135138: Detect errors in Windows packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro marked 2 inline comments as done.
pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:69
 echo.
-pause
 
----------------
mstorsjo wrote:
> hans wrote:
> > pbo-linaro wrote:
> > > hans wrote:
> > > > I liked this, but I can see how it doesn't make sense for everyone.
> > > I'm open to discuss this.
> > > We are using a pre-script that downloads dependencies, and having this one to stop after some time, is not so handy.
> > I think dropping it is fine.
> FWIW, if there's an easy way to check if the current terminal is interactive or not (it's fairly easy to do this for unix shell scripts at least), it could be kept conditionally for such cases I think.
It probably exists for batch indeed. But when used really interactively (like use case I was talking about), the fact it stops is not handy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135138/new/

https://reviews.llvm.org/D135138