[PATCH] D135138: Detect errors in Windows packaging script

[Pierrick Bouvier via Phabricator via llvm-commits]

pbo-linaro marked an inline comment as done.
pbo-linaro added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:69
 echo.
-pause
 
----------------
hans wrote:
> I liked this, but I can see how it doesn't make sense for everyone.
I'm open to discuss this.
We are using a pre-script that downloads dependencies, and having this one to stop after some time, is not so handy.


================
Comment at: llvm/utils/release/build_llvm_release.bat:128
+call "%vsdevcmd%" -arch=x86 || exit /b 1
+ at echo on
 mkdir build32_stage0
----------------
mstorsjo wrote:
> Why this added `@echo on` here? Does `call "%vsdevcmd%"` affect the echo mode of this surrounding script?
Alas yes. Any script called with call "pollutes" current environment, including for echoing commands.
So, an @echo off will disable echo in parent script.
It's equivalent to a "source" in bash, which can be counter intuitive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135138/new/

https://reviews.llvm.org/D135138