[PATCH] D135117: [objdump] Support finding --source via --dsym files

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 23:46:19 PDT 2022


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1293
                               PrettyPrinter &PIP, SourcePrinter &SP,
-                              bool InlineRelocs) {
+                              bool InlineRelocs, const ObjectFile &DbgObj) {
   const MCSubtargetInfo *STI = PrimarySTI;
----------------
Perhaps move DbgObj next to `Obj`? They are both related to `ObjectFile`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135117/new/

https://reviews.llvm.org/D135117



More information about the llvm-commits mailing list