[PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 23:44:31 PDT 2022


MaskRay added inline comments.


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:72
                                    ABI *abi) const {
+
+  std::function<llvm::StringRef(uint64_t DwarfRegNum, bool IsEH)> GetRegName =
----------------
delete blank line


================
Comment at: lldb/source/Expression/DWARFExpression.cpp:74
+  std::function<llvm::StringRef(uint64_t DwarfRegNum, bool IsEH)> GetRegName =
+      nullptr;
+  if (abi) {
----------------
delete `= nullptr`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134817/new/

https://reviews.llvm.org/D134817



More information about the llvm-commits mailing list