[PATCH] D132623: [CodeGen] Disable tail calls at -O0/-O1

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks planned changes to this revision.
aeubanks added a comment.

> At least when I think optnone (or maybe optsize, I forget - I remember it was @chandlerc that was expressing these opinions most vocally) was proposed there was some distinction drawn between semantically meaningful differences (that "optimizing for size" and "not optimizing at all" were observable changes in behavior, in some sense - for debugging, for fitting in certain embedded devices, etc) and "varying shades of optimization" (essentially between -O2 and -O3) - and that the latter didn't seem suitable for per-function granularity expression (& so should be expressed only by the optimization pipeline, not embedded in the IR), but the former did.

The talk I had was actually with Chandler who liked the idea of a unified pipeline that looked at function attributes. (I seemed to remember that you had brought up Chandler being against this before and mentioned it but he had no recollection of being against something like this).

But anyway, we're getting off topic, I'm not actually proposing a unified optimization pipeline. I'll need to find time to understand the tail call vs inlining hurting stack traces issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132623/new/

https://reviews.llvm.org/D132623