[PATCH] D135124: Add f16 nearbyint support.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/fnearbyint.ll:7
 ; so no need to check anything.
 
+declare half @llvm.nearbyint.f16(half) #0
----------------
Leonc wrote:
> arsenm wrote:
> > This test is missing checks somehow 
> Do we want checks for all of the functions? The comment on lines 5-6 suggests the checks were left out intentionally.
The comment is nonsense and it's bad practice to have no checks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135124/new/

https://reviews.llvm.org/D135124