[PATCH] D135117: [objdump] Support finding --source via --dsym files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:7395
+  const MachOObjectFile *DbgObj = MachOOF;
+
+  std::string DSYMPath;
----------------
unneeded blank line


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:7398
+
+  // Auto-detect w/o --dsym
+  if (DSYMFile.empty()) {
----------------
End full sentences with `.`


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:7400
+  if (DSYMFile.empty()) {
+    Twine FilenameDSYM = Filename + ".dSYM";
+    if (llvm::sys::fs::is_directory(FilenameDSYM)) {
----------------
https://llvm.org/docs/ProgrammersManual.html#the-twine-class

Avoid using Twine as a local variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135117/new/

https://reviews.llvm.org/D135117