[PATCH] D131224: [llvm-objdump] Find debug information with Build ID/debuginfod.

[Daniel Thornburgh via Phabricator via llvm-commits]

mysterymath added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:41
+#include "llvm/Debuginfod/Debuginfod.h"
+#include "llvm/Debuginfod/HTTPClient.h"
 #include "llvm/Demangle/Demangle.h"
----------------
thakis wrote:
> Please see the discussion on D113717, in particular the summary at https://reviews.llvm.org/D113717#3295350
> 
> llvm-objdump probably shouldn't depend on HTTPClient, at least by default.
IIRC, it will depend only on the stubbed-out HTTPClient unless LLVM_ENABLE_CURL is set in CMake.
This is parallel to the configure-based optional dependency of binutils and elfutils objdump's on libdebuginfod (and transitively, libcurl).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131224/new/

https://reviews.llvm.org/D131224