[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

Xiang Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 16:23:27 PDT 2022


python3kgae added inline comments.


================
Comment at: llvm/include/llvm/Frontend/HLSL/HLSLResource.h:35
+  GlobalVariable *getGlobalVariable();
+  StringRef getSourceType();
+  Constant *getID();
----------------
Could we save things like shape and component type instead of a StringRef which needs to be parsed later?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135110/new/

https://reviews.llvm.org/D135110



More information about the llvm-commits mailing list