[PATCH] D135022: [GlobalISel] Implement undef combines for funnel shifts

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:763-764
+  /// fshr (x, y, undef) -> y for scalars
+  /// fshl (x, y, undef) -> undef for vectors
+  /// fshr (x, y, undef) -> undef for vectors
+  void applyUndefFunnelShiftAmount(MachineInstr &MI);
----------------
arsenm wrote:
> Different behavior for vector and scalar sounds really broken
Yeah this sounds very sus.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135022/new/

https://reviews.llvm.org/D135022