[PATCH] D132560: [lld-macho] Add initial support for chained fixups

Mon Oct 3 13:44:32 PDT 2022

BertalanD marked 3 inline comments as done.
BertalanD added inline comments.

================
Comment at: lld/MachO/Options.td:1231
+    HelpText<"Emit chained fixups (experimental)">,
+    Group<grp_undocumented>;
+def no_fixup_chains : Flag<["-"], "no_fixup_chains">,
----------------
BertalanD wrote:
> thakis wrote:
> > I think you can move these out of undocumented. The help text says "experimental", that seems clear enough :)
> > 
> > (…and then we won't forget to move it out of undocumented when we enable it by default.)
> I'll move it into `grp_rare` then. `-fixup_chains` is not documented in the ld64 man page, but I guess it's useful enough to move it to be near the less esoteric options. 
Moving out of `grp_undocumented` feels wrong to me. I made the help text slightly more useful though.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132560/new/

https://reviews.llvm.org/D132560