[PATCH] D132560: [lld-macho] Add initial support for chained fixups

[Daniel Bertalan via Phabricator via llvm-commits]

BertalanD marked 15 inline comments as done and an inline comment as not done.
BertalanD added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:358
+  assert(config->emitChainedFixups);
+  assert(target->wordSize == 8 && "Only 64-bit platforms are supported");
+  auto *rebase = reinterpret_cast<dyld_chained_ptr_64_rebase *>(buf);
----------------
thakis wrote:
> Maybe `assert(reinterpret_cast<uintptr_t>(buf) % target->wordSize == 0 && "unaligned fixup address")`? (optional)
We diagnose unaligned fixups when chaining them together in `Writer::buildFixupChains()`. The format actually allows `8k+4`-addresses.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132560/new/

https://reviews.llvm.org/D132560