[PATCH] D135095: [test][InstCombine] Update some more test cases to use opaque pointers

Mon Oct 3 12:29:35 PDT 2022

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

> but there was also a need to re-run update_test_checks.py (impacting nonnull/dereferencable attributes).

I looked into this, and it's quite embarrassing: isKnownZero() does not support bitcast and GEP constant expressions: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Analysis/ValueTracking.cpp#L2484-L2492

While the bitcast case is no longer relevant, we should probably add const expr GEP support.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135095/new/

https://reviews.llvm.org/D135095