[PATCH] D135014: [lld][ELF] Fix lazy ThinLTO index writing in thin archives

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 11:52:04 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-index-files-thin-archive.ll:1
+;; Make sure that when we are linking against a thin archive in a different
+;; folder from the object files it references, bitcode files that have
----------------
MaskRay wrote:
> The comment may be too long. I'll suggest
> 
> For a thin archive referencing object files in a different directory, emit index files (`lib.a($member at $offset).thinlto.bc`) in the directory containing the archive.
For a thin archive referencing object files in a different directory, emit index files (lib.a($member at $offset).thinlto.bc) in the directory containing the archive. The information about the referenced member's directory is lost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135014/new/

https://reviews.llvm.org/D135014



More information about the llvm-commits mailing list