[PATCH] D115737: [IPSCCP] Partial support for constrained intrinsics

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 11:49:03 PDT 2022


kpn added a comment.

In D115737#3615950 <https://reviews.llvm.org/D115737#3615950>, @nikic wrote:

> Why isn't this already handled by ConstantFoldCall?

Because ConstantFoldCall() is called from handleCallResult(), and we're skipping that part of handleCallBase() due to having constrained fcmp/fcmps behave just like the non-constrained. Instead we're constant folding in visitCmpInst().

Also, a constrained fcmp/fcmps is !isa<Function>, so while it is not overdefined, it does not fall into the block in markUsersAsChanged() that calls ConstantFoldCall().

I'll update the diff in a minute with the right set of tests...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115737/new/

https://reviews.llvm.org/D115737



More information about the llvm-commits mailing list