[PATCH] D131224: [llvm-objdump] Find debug information with Build ID/debuginfod.

Mon Oct 3 10:37:33 PDT 2022

mysterymath added a comment.

In D131224#3825238 <https://reviews.llvm.org/D131224#3825238>, @MaskRay wrote:

> The patch is not uploaded via `arc diff 'HEAD^'` or web interface (`git format-patch -1 --stdout`). I got:
>
>   % curl -L 'https://reviews.llvm.org/D131224?download=1' | patch -p1
>     % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                    Dload  Upload   Total   Spent    Left  Speed
>   100 10725    0 10725    0     0  47865      0 --:--:-- --:--:-- --:--:-- 48094
>   patch unexpectedly ends in middle of line
>   patch: **** Only garbage was found in the patch input.
>   % arc patch D131224
>   ...
>    COMMITTED  Successfully committed patch.
>   
>    Cherry Pick Failed!
>    Exception 
>   Command failed with error #1!
>   COMMAND
>   git cherry-pick -- arcpatch-D132504
>   
>   STDOUT
>   On branch arcpatch-D131224
>   You are currently cherry-picking commit eae436e3098c.

Strange; I've been using the vanilla `arc diff` workflow. Maybe it went out of date from the changes to the prior, and I hadn't yet reuploaded? Just sent a fresh version of the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131224/new/

https://reviews.llvm.org/D131224