[PATCH] D135070: [TTI][Sink] Add target support for sinking more reads

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Sink.cpp:84
     // other code paths.
-    if (Inst->mayReadFromMemory())
+    if (Inst->mayReadFromMemory() && !TTI.canAlwaysSinkRead(Inst, SuccToSinkTo))
       return false;
----------------
foad wrote:
> Why not check MD_invariant_load directly here, rather than forcing every target to check it in their own canAlwaysSinkRead hook?
I agree, I don't see why this needs to be a target hook. We already have AA checks for invariant memory 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135070/new/

https://reviews.llvm.org/D135070