[PATCH] D133584: [DAGCombiner] [AMDGPU] Allow vector loads in MatchLoadCombine
Jeffrey Byrnes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 3 09:21:41 PDT 2022
jrbyrnes added a comment.
In D133584#3830968 <https://reviews.llvm.org/D133584#3830968>, @spatel wrote:
> I still can't say that I see all of the potential corner cases, but the extra comments help to explain what's going on, and it seems to work as expected, so LGTM.
> Might still be good to get a 2nd approval from another reviewer since several people have commented.
Hey @spatel , thanks! I appreciate your help and thoughts on this patch. I'll keep the review up for a bit longer while I do some testing to see if anyone else is willing to approve.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133584/new/
https://reviews.llvm.org/D133584
More information about the llvm-commits
mailing list