[PATCH] D134938: [libc++] Add option to disable long double math support in libc++

[Michael Platings via Phabricator via llvm-commits]

michaelplatings added a comment.

Hi Nikolas,

I confirm that using builtins as you propose does solve the problem. And it works without explicitly setting any option, so that's even better. Yes, if you try to use a long double math function then you get an error at link time, but I think that's fine.

I look forward to your patch. If you're short of time then let me know and I can give it a go.

> One location that I believe is missing from this patch is the call to atan2l in include/complex.

Thanks Alexander, you're quite right that including <complex> does produce a compile-time error without patching. So that would be another place that needs the builtin treatment, or changing to call one of the atan2 overloads. I went hunting for other headers that might need changing but didn't find any.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134938/new/

https://reviews.llvm.org/D134938