[PATCH] D135038: [lld/mac] Port typo correction for undefined symbols from ELF port

Mon Oct 3 08:24:50 PDT 2022

oontvoo accepted this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

Nice! LGTM
(it seems patch-application still failed - probably need sync'ing again?)

================
Comment at: lld/MachO/SymbolTable.cpp:413
+// file of sym.
+static const Symbol *getAlternativeSpelling(const Undefined &sym,
+                                            std::string &pre_hint,
----------------
This function does some intensive works - is it worth caching the results? 

(OTOTH, maybe performance isn't important in case of failures, anyways 🤔 )

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135038/new/

https://reviews.llvm.org/D135038