[PATCH] D134999: AArch64: PAC: Do not attempt ICP on authenticating calls.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

The change itself looks fine to me, although needs a comment. But this would be better to test in llvm/test/Transforms/PGOProfile (see the icp_* and indirect_call_promotion* tests in that directory). The SampleProfile tests seem more geared towards specifically testing the SamplePGO matching related issues, and this is a more generic ICP fix. Thus the tests in PGOProfile don't tend to use a separate input file with the profile, rather the profile is already embedded in the IR with VP metadata.



================
Comment at: llvm/lib/Transforms/Utils/CallPromotionUtils.cpp:388
 
+  if (CB.countOperandBundlesOfType(LLVMContext::OB_ptrauth)) {
+    if (*FailureReason)
----------------
Please add a comment here about why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134999/new/

https://reviews.llvm.org/D134999