[PATCH] D88573: [SelectionDAG] Add check for BUILD_VECTOR in isKnownNeverNaN
Petar Avramovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 3 03:48:51 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1fa2019828ca: [SelectionDAG] Add check for BUILD_VECTOR in isKnownNeverNaN (authored by Petar.Avramovic).
Changed prior to commit:
https://reviews.llvm.org/D88573?vs=295523&id=464647#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88573/new/
https://reviews.llvm.org/D88573
Files:
llvm/include/llvm/CodeGen/SelectionDAG.h
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -4683,7 +4683,6 @@
if (Depth >= MaxRecursionDepth)
return false; // Limit search depth.
- // TODO: Handle vectors.
// If the value is a constant, we can obviously see if it is a NaN or not.
if (const ConstantFPSDNode *C = dyn_cast<ConstantFPSDNode>(Op)) {
return !C->getValueAPF().isNaN() ||
@@ -4781,6 +4780,12 @@
case ISD::EXTRACT_VECTOR_ELT: {
return isKnownNeverNaN(Op.getOperand(0), SNaN, Depth + 1);
}
+ case ISD::BUILD_VECTOR: {
+ for (const SDValue &Opnd : Op->ops())
+ if (!isKnownNeverNaN(Opnd, SNaN, Depth + 1))
+ return false;
+ return true;
+ }
default:
if (Opcode >= ISD::BUILTIN_OP_END ||
Opcode == ISD::INTRINSIC_WO_CHAIN ||
Index: llvm/include/llvm/CodeGen/SelectionDAG.h
===================================================================
--- llvm/include/llvm/CodeGen/SelectionDAG.h
+++ llvm/include/llvm/CodeGen/SelectionDAG.h
@@ -2027,9 +2027,9 @@
/// X|Cst == X+Cst iff X&Cst = 0.
bool isBaseWithConstantOffset(SDValue Op) const;
- /// Test whether the given SDValue is known to never be NaN. If \p SNaN is
- /// true, returns if \p Op is known to never be a signaling NaN (it may still
- /// be a qNaN).
+ /// Test whether the given SDValue (or all elements of it, if it is a
+ /// vector) is known to never be NaN. If \p SNaN is true, returns if \p Op is
+ /// known to never be a signaling NaN (it may still be a qNaN).
bool isKnownNeverNaN(SDValue Op, bool SNaN = false, unsigned Depth = 0) const;
/// \returns true if \p Op is known to never be a signaling NaN.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88573.464647.patch
Type: text/x-patch
Size: 1812 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221003/16a4a9ce/attachment.bin>
More information about the llvm-commits
mailing list