[PATCH] D134946: [AArch64][SVE] Use flag setting variants of BRKB/BRKN/RDFFR

[Bradley Smith via Phabricator via llvm-commits]

bsmith accepted this revision.
bsmith added a comment.
This revision is now accepted and ready to land.

LGTM with minor nits



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1335
+    auto *PredMask = MRI->getUniqueVRegDef(Pred->getOperand(1).getReg());
+    if (Mask != PredMask && (Mask != Pred))
+      return false;
----------------
Extra parenthesis


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:1344-1346
       // Check to see if our mask is the same as the brkpb's. If
       // not the resulting flag bits may be different and we
       // can't remove the ptest.
----------------
This comment is out of place now


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134946/new/

https://reviews.llvm.org/D134946