[PATCH] D110585: [Analysis][SimplifyLibCalls] Refactor code related to size_t in lib func signatures. NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 02:05:30 PDT 2022


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:196
 
+  /// Returns the size of the size_t type in bits or 0 if the size is unknown.
+  unsigned getSizeTSize(const Module &M) const;
----------------
Drop "or 0 is the size is unknown". This size must be known.


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:1233
+  // If that isn't true then it should be possible to derive the SizeTTy from
+  // the target tripe here instead and do an early return.
+
----------------
triple


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110585/new/

https://reviews.llvm.org/D110585



More information about the llvm-commits mailing list