[PATCH] D134464: [LLD][COFF] Reduce chance of symbol name collision with delay-load
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 3 00:59:24 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0ce4f57052c3: [LLD][COFF] Reduce chance of symbol name collision with delay-load (authored by alvinhochun, committed by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134464/new/
https://reviews.llvm.org/D134464
Files:
lld/COFF/DLL.cpp
Index: lld/COFF/DLL.cpp
===================================================================
--- lld/COFF/DLL.cpp
+++ lld/COFF/DLL.cpp
@@ -659,10 +659,10 @@
auto *c = make<HintNameChunk>(extName, 0);
names.push_back(make<LookupChunk>(c));
hintNames.push_back(c);
- // Add a syntentic symbol for this load thunk, using the "__imp_load"
+ // Add a syntentic symbol for this load thunk, using the "__imp___load"
// prefix, in case this thunk needs to be added to the list of valid
// call targets for Control Flow Guard.
- StringRef symName = saver().save("__imp_load_" + extName);
+ StringRef symName = saver().save("__imp___load_" + extName);
s->loadThunkSym =
cast<DefinedSynthetic>(ctx.symtab.addSynthetic(symName, t));
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134464.464615.patch
Type: text/x-patch
Size: 824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221003/fe981842/attachment.bin>
More information about the llvm-commits
mailing list