[PATCH] D134336: [AArch64] Lower multiplication by a constant int to madd

[Allen zhong via Phabricator via llvm-commits]

Allen marked 2 inline comments as done.
Allen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5800
     // ADD R,I,Imm
-    // ==> ORR  V, ZR, Imm
+    // ==> ORR  V, ZR, Imm or MOV V, Imm
     // ==> MADD R,A,B,V
----------------
efriedma wrote:
> Just make this say "mov", since that's always the alias.
Done


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.cpp:5840
+                 .addImm(MovI->Op2);
+    else
+      MIB1 = BuildMI(MF, Root.getDebugLoc(), TII->get(MovI->Opcode), NewVR)
----------------
efriedma wrote:
> Maybe assert that the opcode is movn or movz here?  For documentation.
Apply your comment, thanks 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134336/new/

https://reviews.llvm.org/D134336