[PATCH] D133480: [llvm-dwp] Get the DWO file from relative path if the absolute path is not valid

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/tools/llvm-dwp/X86/search_dwos.test:12
+
+clang++ -Xclang -fdebug-compilation-dir -Xclang "/tmp" -g -O0 -gsplit-dwarf a.cpp b.cpp -o main
+
----------------
steven.zhang wrote:
> dblaikie wrote:
> > maybe use a less-likely-to-accidentally-exist path rather than `/tmp` (`/non-existent` or something?) (& any ideas how this works if the test runs on Windows? does the absolute path confuse things? maybe using a relative comp-dir like `non-existent` (without the leading `/`) would be better? Not sure how the other tests work already
> Good point. `path-not-exists` I will use. 
this test is failing on my machine because I have a `/tmp/a.dwo` with a different dwarf version. I think the checked in binaries are still using `/tmp`, could that be fixed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133480/new/

https://reviews.llvm.org/D133480