[PATCH] D134990: [CMake] Provide Findzstd module

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 2 08:46:22 PDT 2022


mgorny added inline comments.


================
Comment at: llvm/cmake/modules/Findzstd.cmake:22
+if(ZSTD_FOUND)
+  if("${ZSTD_LIBRARY}" MATCHES "\\${CMAKE_SHARED_LIBRARY_SUFFIX}$" AND
+     NOT TARGET zstd::libzstd_shared)
----------------
Pointed out by Rolf Eike Beer, the man with the coolest name in Gentoo ;-).


================
Comment at: llvm/cmake/modules/Findzstd.cmake:29
+  endif()
+  if("${ZSTD_LIBRARY}" MATCHES "\\${CMAKE_STATIC_LIBRARY_SUFFIX}$" AND
+     NOT TARGET zstd::libzstd_static)
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134990/new/

https://reviews.llvm.org/D134990



More information about the llvm-commits mailing list