[PATCH] D134606: [LAA] Change to function analysis for new PM.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopVersioningLICM.cpp:674
 
-  auto GetLAI = [&](Loop *L) -> const LoopAccessInfo & {
-    return AM.getResult<LoopAccessAnalysis>(*L, LAR);
-  };
-
+  LoopAccessInfoManager LAIs(*SE, *AA, *DT, *LI, nullptr);
+  std::function<const LoopAccessInfo &(Loop *)> GetLAI =
----------------
aeubanks wrote:
> this is the most concerning part since we're not taking advantage of caching between invocations of LVLICM, but if compile times look ok then sure
Thanks, I'll keep an eye out for regressions. I am not sure if anybody actually uses LoopVersioningLICM, but even if they do, constructing `LoopAccessInfoManager` should be cheap and `getInfo` only analyzes the requested loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134606/new/

https://reviews.llvm.org/D134606