[PATCH] D134916: [llvm-ocaml] Add binding for constructing opaque pointers

Alan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 21:32:56 PDT 2022


alan added a comment.

I just updated the diff to remove the `PointerType::isOpaque` binding I added. The only reason I added that was to write a test case checking if a pointer was opaque, which I had *misunderstood* and written incorrectly, as @nikic pointed out. As @aeubanks pointed out, users should assume that all pointers are opaque now (as LLVM is migrating to opaque pointers), so the `isOpaque` binding perhaps should not be added.

I just want to merge a patch into the main branch to add OCaml bindings for constructing opaque pointers without passing a pointee type. If one were to decide that `isOpaque` also needs bindings, I think that can be a separate patch after this one is finished.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134916/new/

https://reviews.llvm.org/D134916



More information about the llvm-commits mailing list