[PATCH] D134916: [llvm-ocaml] Add binding for constructing opaque pointers

Alan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 17:47:39 PDT 2022


alan updated this revision to Diff 464449.
alan added a comment.

[llvm-ocaml] Add binding for constructing opaque pointers


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134916/new/

https://reviews.llvm.org/D134916

Files:
  llvm/bindings/ocaml/llvm/llvm.mli
  llvm/test/Bindings/OCaml/core.ml


Index: llvm/test/Bindings/OCaml/core.ml
===================================================================
--- llvm/test/Bindings/OCaml/core.ml
+++ llvm/test/Bindings/OCaml/core.ml
@@ -44,7 +44,7 @@
 (*===-- Pointer types  ----------------------------------------------------===*)
 let test_pointer_types () =
   insist (pointer_type_is_opaque (pointer_type_in_context context 0));
-  insist (not (pointer_type_is_opaque (pointer_type i8_type)))
+  insist (pointer_type_is_opaque (pointer_type i8_type))
 
 (*===-- Conversion --------------------------------------------------------===*)
 
@@ -1508,6 +1508,7 @@
   suite "contained types"  test_contained_types;
   suite "conversion"       test_conversion;
   suite "target"           test_target;
+  suite "pointer types"    test_pointer_types;
   suite "constants"        test_constants;
   suite "attributes"       test_attributes;
   suite "global values"    test_global_values;
Index: llvm/bindings/ocaml/llvm/llvm.mli
===================================================================
--- llvm/bindings/ocaml/llvm/llvm.mli
+++ llvm/bindings/ocaml/llvm/llvm.mli
@@ -727,7 +727,7 @@
 val qualified_pointer_type : lltype -> int -> lltype
 
 (** [pointer_type_in_context context as] returns the opaque pointer type
-    referencing objects in address [as].
+    referencing objects in address space [as].
     See the method [llvm::PointerType::get]. *)
 val pointer_type_in_context : llcontext -> int -> lltype
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134916.464449.patch
Type: text/x-patch
Size: 1468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221001/0c56417b/attachment.bin>


More information about the llvm-commits mailing list