[PATCH] D133902: X86: Stop assigning register costs for longer encodings

Fri Sep 30 17:36:59 PDT 2022

mtrofin added a comment.

In D133902#3828661 <https://reviews.llvm.org/D133902#3828661>, @MatzeB wrote:

> I'm not sure I have 100% fixed it, we'll see :)
>
> Also thinking about things right now, I realized that my change probably lowers the amount of times ragreedy asks for eviction decisions. I hope that doesn't reduce the quality of ML regalloc, maybe you can keep on eye on that on your end.
>
> (I'm happy to revert if it decreases quality, though we have to find a better way than somewhat "arbitrary" CostPerUse / high register numbers triggering things long-term...)

I tried it with your change already, didn't see anything for the workload I looked at - anyway, we can always retrain it if needed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133902/new/

https://reviews.llvm.org/D133902