[PATCH] D134915: [X86] Do not emit JCC to __x86_indirect_thunk

[Joao Moreira via Phabricator via llvm-commits]

joaomoreira added inline comments.


================
Comment at: llvm/test/CodeGen/X86/jcc-indirect-thunk-kernel.ll:16-17
+entry:
+  %0 = load void()*, void()** %something, align 8
+  %tobool.not = icmp eq void()* %0, null
+  br i1 %tobool.not, label %if.end, label %if.then
----------------
nickdesaulniers wrote:
> I'm surprised to see typed pointers, since we've enabled [[ https://llvm.org/docs/OpaquePointers.html | opaque pointers ]]. Was this test case generated from an older release of llvm? I'd have expected
> 
> ```
> %0 = load ptr, ptr %something, align 8
> %tobool.not = icmp eq ptr %0, null
> ```
> no `void()*` or `void()**`. Please change this, and triple check if you're using an older version of llvm for development, or have something wrong in your cmakecache. We'd like to eliminate non-opaque ptrs from the codebase, IIUC.
The test was not fully generated out of a kernel use case. After generating the IR for the test, I tweaked a lot by hand. I wasn't up to date with the changes (in fact, I very rarely touch IR as I'm normally working on the backend), thanks for updating me. I'll fix this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134915/new/

https://reviews.llvm.org/D134915