[PATCH] D134916: [llvm-ocaml] Add binding for constructing opaque pointers

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D134916#3827035 <https://reviews.llvm.org/D134916#3827035>, @alan wrote:

> I've updated the patch by making a new feature branch and squash merging the old one into the new one. Now, both my commits are included in the diff. Was there a better way for me to have done this?

Sounds like the right thing to do in this case. Phabricator doesn't do multi-commit reviews, you need one review per commit (though they can be dependent).



================
Comment at: llvm/test/Bindings/OCaml/core.ml:47
+  insist (pointer_type_is_opaque (pointer_type_in_context context 0));
+  insist (not (pointer_type_is_opaque (pointer_type i8_type)))
 
----------------
Hm, does this test really pass? It's not possible to mix opaque and typed pointers in the same context. The second call should be creating an opaque pointer as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134916/new/

https://reviews.llvm.org/D134916