[PATCH] D134606: [LAA] Change to function analysis for new PM.

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 11:55:27 PDT 2022


aeubanks accepted this revision.
aeubanks added a comment.
This revision is now accepted and ready to land.

lg if compile times aren't affected



================
Comment at: llvm/lib/Transforms/Scalar/LoopVersioningLICM.cpp:674
 
-  auto GetLAI = [&](Loop *L) -> const LoopAccessInfo & {
-    return AM.getResult<LoopAccessAnalysis>(*L, LAR);
-  };
-
+  LoopAccessInfoManager LAIs(*SE, *AA, *DT, *LI, nullptr);
+  std::function<const LoopAccessInfo &(Loop *)> GetLAI =
----------------
this is the most concerning part since we're not taking advantage of caching between invocations of LVLICM, but if compile times look ok then sure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134606/new/

https://reviews.llvm.org/D134606



More information about the llvm-commits mailing list