[PATCH] D131310: [llvm-driver] Support single distributions

Fri Sep 30 11:42:25 PDT 2022

abrachet marked an inline comment as done.
abrachet added a comment.

In D131310#3821479 <https://reviews.llvm.org/D131310#3821479>, @phosek wrote:

> Since distributions are used for selecting components that are distributed in the toolchain, and most vendors only have a single distribution, I'd prefer using the name `llvm` (rather than `llvm-distribution`) for the default distribution since that binary is going to be shipped in the toolchain (and "distribution" is an internal  concept that users shouldn't be concerned with).
>
> I wonder if we could use the following approach:
>
> - If `LLVM_DISTRIBUTION_COMPONENTS` isn't set, then combine all supported tools into `llvm` driver.
> - If `LLVM_DISTRIBUTION_COMPONENTS` is set, then combine all supported tools listed in `LLVM_DISTRIBUTION_COMPONENTS` into `llvm` driver and leave all other tools standalone.
> - (In the future) If `LLVM_DISTRIBUTIONS` is set, then combine all supported tools listed in `LLVM_<name>_DISTRIBUTION_COMPONENTS` into `llvm-<name>` driver and leave all other tools standalone.
>
> What do you think?

Sounds good. 1 and 2 have been implemented and 3 has been saved for later

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131310/new/

https://reviews.llvm.org/D131310