[PATCH] D134954: [InstCombine] Switch foldOpIntoPhi() to use InstSimplify

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

I haven't followed the nuances of inttoptr/ptrtoint folding, but I assume those diffs are valid. See inline for one question.



================
Comment at: llvm/test/Transforms/InstCombine/recurrence.ll:7
 ; CHECK-NEXT:  entry:
+; CHECK-NEXT:    [[TMP0:%.*]] = or i64 [[A:%.*]], 15
 ; CHECK-NEXT:    br label [[LOOP:%.*]]
----------------
This is an improvement, but it's not clear to me from the diffs or debug spew why it happened. Did you step through to look at that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134954/new/

https://reviews.llvm.org/D134954