[PATCH] D133192: [LICM] Allow load-only scalar promotion in the presence of aliasing loads

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Analysis/AliasSetTracker.cpp:254
+        Inst, MemoryLocation(I.getPointer(), I.getSize(), I.getAAInfo()));
+    if (isModAndRefSet(MR))
+      return MR;
----------------
reames wrote:
> I think you can early return here if mod is set.  The only reason to check for both is if the result mod-noref is useful, and I don't think it is right now. 
I gave this a try, but it did not make a measurable difference.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133192/new/

https://reviews.llvm.org/D133192