[PATCH] D134935: [VP][RISCV] Add vp.copysign and RISC-V support.

Fri Sep 30 09:42:45 PDT 2022

craig.topper added a comment.

In D134935#3825988 <https://reviews.llvm.org/D134935#3825988>, @fakepaper56 wrote:

> `ISD::FCOPYSIGN` could have different types of magnitude operand and sign operand. Should `ISD::VP_FOPYSIGN` have same property? My implements does not loose the constraint like other vp intrinsics.

I don't think we should support differing types for ISD::VP_COPYSIGN. It was disabled for vector ISD::FCOPYSIGN in February 2021 D96037 <https://reviews.llvm.org/D96037>  Though it look likes a command line flag was added to DAGCombiner.cpp in August 2022 to allow it to be re-enabled. Using that flag would very likely cause isel failures on RISC-V.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134935/new/

https://reviews.llvm.org/D134935