[PATCH] D134840: [AArch64] Unit test for trunc lowering from i64 to i8

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 30 07:45:17 PDT 2022


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/test/CodeGen/AArch64/trunc-to-tbl.ll:320
+define void @trunc_v8i64_to_v8i8_in_loop(ptr %A, ptr %dst) {
+
+; CHECK-LABEL:	trunc_v8i64_to_v8i8_in_loop:
----------------
nit: remove newline here


================
Comment at: llvm/test/CodeGen/AArch64/trunc-to-tbl.ll:384
+define void @trunc_v8i19_to_v8i8_in_loop(ptr %A, ptr %dst) {
+
+; CHECK-LABEL:	trunc_v8i19_to_v8i8_in_loop:
----------------
nit: remove newline here


================
Comment at: llvm/test/CodeGen/AArch64/trunc-to-tbl.ll:464
+
+
+entry:
----------------
nit: remove newline here


================
Comment at: llvm/test/CodeGen/AArch64/trunc-to-tbl.ll:484
+define void @trunc_v11i64_to_v11i8_in_loop(ptr %A, ptr %dst) {
+
+; CHECK-LABEL:	trunc_v11i64_to_v11i8_in_loop:
----------------
nit: remove newline here


================
Comment at: llvm/test/CodeGen/AArch64/trunc-to-tbl.ll:548
+
+
+entry:
----------------
nit: remove newline here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134840/new/

https://reviews.llvm.org/D134840



More information about the llvm-commits mailing list